Skip to content

Commit

Permalink
updated airlock docs with new view changes (#753)
Browse files Browse the repository at this point in the history
  • Loading branch information
Providence-o authored Feb 4, 2025
1 parent 8b683d3 commit 8b1e5a8
Show file tree
Hide file tree
Showing 34 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion airlock/templates/requests_for_output_checker.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

{% block content %}
<div class="flex flex-col gap-4 max-w-3xl">
{% airlock_header title="Requests" %}
{% airlock_header title="Requests for review" %}

{% #card title="Outstanding requests awaiting review" %}
{% #list_group id="outstanding-requests" %}
Expand Down
12 changes: 3 additions & 9 deletions docs/how-tos/review-a-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,11 @@ each requested file.

## View release requests that require action

Use the navigation bar link to view all requests.
Use the navigation bar link to view all requests for review.

![Requests index](../screenshots/requests_index.png)

This page shows you any release requests that you have authored, and any
release requests that are currently active.

!!! note
If you are not an output checker you will only see requests that you
have authored on this page.
![Reviews index](../screenshots/reviews_index.png)

This page shows you any release requests that are currently active.

### Outstanding requests awaiting review
These are requests that have been submitted and are awaiting or under review.
Expand Down
Binary file modified docs/screenshots/context_and_controls.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/context_modal.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/file_approved.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/file_group.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/file_review.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/files_released.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/markdown_comment_blockquote_1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/markdown_comment_bold_2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/markdown_comment_ordered_list_2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/multiselect_update.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/ready_to_release.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/request_independent_review_file_icons.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/request_overview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/request_reviewed_file_icons.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/request_tree.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/request_tree_post_voting.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed docs/screenshots/requests_index.png
Binary file not shown.
Binary file modified docs/screenshots/returned_request_comments.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/returned_tree.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/reviewed_request_comments.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/screenshots/reviews_index.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/submit_request.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/submit_review.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/submitted_request.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/screenshots/submitted_review.png
Binary file modified docs/screenshots/withdraw_request.png
Binary file modified docs/screenshots/withdraw_request_modal.png
Binary file modified docs/screenshots/withdrawn_file.png
Binary file modified docs/screenshots/workspace_directory_content.png
Binary file modified docs/screenshots/workspace_directory_view.png
6 changes: 3 additions & 3 deletions tests/functional/test_docs_screenshots.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,9 @@ def do_review(screenshot=True):

# Login as output checker and visit pages
login_as_user(live_server, context, user_dicts["checker1"])
# Requests index
page.goto(f"{live_server.url}/requests")
page.screenshot(path=settings.SCREENSHOT_DIR / "requests_index.png")
# Reviews index page
page.goto(f"{live_server.url}/requests/output_checker")
page.screenshot(path=settings.SCREENSHOT_DIR / "reviews_index.png")
# Request view
page.goto(live_server.url + release_request.get_url())
page.screenshot(path=settings.SCREENSHOT_DIR / "request_overview.png")
Expand Down

0 comments on commit 8b1e5a8

Please sign in to comment.