Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for maven settings deserialization #4971

Closed
wants to merge 2 commits into from
Closed

Add failing test for maven settings deserialization #4971

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e3b7e3
Add failing test for maven settings deserialization
pstreef Jan 29, 2025
2068ece
fix failing test
pstreef Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 30 additions & 19 deletions rewrite-maven/src/test/java/org/openrewrite/maven/MavenSettingsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package org.openrewrite.maven;

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.core.JsonProcessingException;
import org.assertj.core.api.Condition;
import org.assertj.core.api.InstanceOfAssertFactories;
import org.assertj.core.api.ThrowingConsumer;
Expand Down Expand Up @@ -825,23 +826,23 @@ void serverHttpHeaders() {
@Test
void canDeserializeSettingsCorrectly() throws IOException {
Xml.Document parsed = (Xml.Document) XmlParser.builder().build().parse("""
<settings>
<servers>
<server>
<id>maven-snapshots</id>
<configuration>
<timeout>10000</timeout>
<httpHeaders>
<property>
<name>X-JFrog-Art-Api</name>
<value>myApiToken</value>
</property>
</httpHeaders>
</configuration>
</server>
</servers>
</settings>
""").findFirst().get();
<settings>
<servers>
<server>
<id>maven-snapshots</id>
<configuration>
<timeout>10000</timeout>
<httpHeaders>
<property>
<name>X-JFrog-Art-Api</name>
<value>myApiToken</value>
</property>
</httpHeaders>
</configuration>
</server>
</servers>
</settings>
""").findFirst().get();

MavenSettings.HttpHeader httpHeader = new MavenSettings.HttpHeader("X-JFrog-Art-Api", "myApiToken");
MavenSettings.ServerConfiguration configuration = new MavenSettings.ServerConfiguration(java.util.Collections.singletonList(httpHeader), 10000L);
Expand All @@ -859,7 +860,17 @@ void canDeserializeSettingsCorrectly() throws IOException {
.isPresent()
.get(InstanceOfAssertFactories.type(Xml.Document.class))
.isNotNull()
.satisfies(serialized -> assertThat(SemanticallyEqual.areEqual(parsed, serialized)).isTrue())
.satisfies(serialized -> assertThat(serialized.printAll().replace("\r", "")).isEqualTo(parsed.printAll()));
.satisfies(serialized -> assertThat(SemanticallyEqual.areEqual(parsed, serialized)).isTrue())
.satisfies(serialized -> assertThat(serialized.printAll().replace("\r", "")).isEqualTo(parsed.printAll()));
}

@Test
void failingDeserialization() throws JsonProcessingException {
//language=xml
String xml = """
<settings>
</settings>
""";
MavenSettings settings = MavenXmlMapper.writeMapper().readValue(xml, MavenSettings.class);
}
}
Loading