Amending YAML parser to add support for tags #4934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Adding support for tags in YAML, e.g.
!Dynamois a tag here.What's your motivation?
Observed in real-life YAMLs that they sometimes use tags.
Currently they have been accidentally supported in some cases. E.g. for scalars we used to consider
!Dynamo Titleto be the value.Anything in particular you'd like reviewers to focus on?
The LST model for YAML has been amended to include two new fields called
taginScalarandSequence. Which is not fully backward compatible. E.g. if someone has a recipe which doesnew Yaml.Scalar(...), the code will no longer compile for 1 extra argument missing.Not sure how do we provide coverage for these scenarios.