Compact GitProvenance.Committer representation
#4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The in-memory representation of the `GitProvenance.Committer` requires quite a lot of memory for the commit statistics as captured by the `TreeMap<LocalDate, Integer>` structure. Replacing with two more compact `int[]` fields.
anandfresh
approved these changes
May 20, 2024
# Conflicts: # rewrite-core/src/main/java/org/openrewrite/marker/GitProvenance.java # rewrite-core/src/main/java/org/openrewrite/search/FindCommitters.java # rewrite-core/src/test/java/org/openrewrite/search/FindCommittersTest.java
|
Comparing for the example of dotnet/runtime the difference in retained memory by the $ echo "Commits: $(git rev-list --count --since="90 days ago" HEAD)" && \
echo "Committers: $(git log --since="90 days ago" --format='%ae' | sort | uniq | wc -l)"
Commits: 831
Committers: 164Although maybe what is more important is the total: $ echo "Commits: $(git rev-list --count HEAD)" && \
echo "Committers: $(git log --format='%ae' | sort | uniq | wc -l)"
Commits: 137292
Committers: 3054While dotnet/runtime is not the Linux kernel, it is still a substantially large repo. Looking at tensorflow/tensorflow: $ echo "Commits: $(git rev-list --count HEAD)" && \
echo "Committers: $(git log --format='%ae' | sort | uniq | wc -l)"
Commits: 175122
Committers: 4468we get: 6028288 vs 1523496 bytes. More optimizations are possible by only keeping one array. This would in the previous example yield an in-memory size of 1391976. Or alternatively replace the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in-memory representation of the
GitProvenance.Committerrequires quite a lot of memory for the commit statistics as captured by theTreeMap<LocalDate, Integer>structure. Replacing with two more compactint[]fields.