Add fix for operators #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdebruin
added
bug
|
|
||
| def visit_variable(self, named_variable: VariableDeclarations.NamedVariable, p: P) -> J: | ||
| v = cast(VariableDeclarations.NamedVariable, super().visit_variable(named_variable, p)) | ||
| if v.padding.initializer is not None and v.padding.initializer.element is not None: |
There was a problem hiding this comment.
I think we here probably need to limit this to method parameter declarations. Currently this would also apply to other variables (e.g. class fields or local variables). Or does the IntelliJ setting also apply to other types of variables?
There was a problem hiding this comment.
I agree that this code is only relevant for the eq_in_named_parameter and, more specifically, when it's set to False, which is not the default. I am not quite sure what the best approach here would be, so for now, I removed the snippet from this PR as the rest of the operators are independent.
There was a problem hiding this comment.
The trick would be to use the cursor to check if the parent tree is a method declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR adds many more tests for the around operators and corrects some bugs.
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist