refactor: OpenRewrite recipe best practices

Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/XX1hrwagC?organizationId=T3BlblJld3JpdGU%3D Co-authored-by: Moderne <[email protected]>
openrewrite · Dec 8, 2023 · fb0efc1 · fb0efc1
1 parent ea6add5
commit fb0efc1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/src/main/java/org/openrewrite/micrometer/TimerToObservation.java b/src/main/java/org/openrewrite/micrometer/TimerToObservation.java
@@ -67,17 +67,17 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
                     private final ChangeMethodName changeRecord = new ChangeMethodName(OBSERVATION + " record*(..)", "observe", null, null);
 
                     @Override
-                    public J.CompilationUnit visitCompilationUnit(J.CompilationUnit compilationUnit, ExecutionContext executionContext) {
+                    public J.CompilationUnit visitCompilationUnit(J.CompilationUnit compilationUnit, ExecutionContext ctx) {
                         J.CompilationUnit cu = compilationUnit;
-                        cu = (J.CompilationUnit) changeTypeRegistry.getVisitor().visit(cu, executionContext);
-                        cu = (J.CompilationUnit) changeTypeTimer.getVisitor().visit(cu, executionContext);
-                        cu = (J.CompilationUnit) changeRecord.getVisitor().visit(cu, executionContext);
+                        cu = (J.CompilationUnit) changeTypeRegistry.getVisitor().visit(cu, ctx);
+                        cu = (J.CompilationUnit) changeTypeTimer.getVisitor().visit(cu, ctx);
+                        cu = (J.CompilationUnit) changeRecord.getVisitor().visit(cu, ctx);
                         assert cu != null;
-                        return super.visitCompilationUnit(cu, executionContext);
+                        return super.visitCompilationUnit(cu, ctx);
                     }
 
                     @Override
-                    public J.MethodInvocation visitMethodInvocation(J.MethodInvocation mi, ExecutionContext executionContext) {
+                    public J.MethodInvocation visitMethodInvocation(J.MethodInvocation mi, ExecutionContext ctx) {
                         if (registerMatcher.matches(mi)) {
                             Expression timerName = null;
                             Expression registry = mi.getArguments().get(0);
@@ -123,19 +123,19 @@ else if (tagsMatcher.matches(maybeBuilder)) {
                                                 + String.join("", builder))
                                         .contextSensitive()
                                         .javaParser(JavaParser.fromJavaVersion()
-                                                .classpathFromResources(executionContext, "micrometer-observation", "micrometer-commons", "micrometer-core"))
+                                                .classpathFromResources(ctx, "micrometer-observation", "micrometer-commons", "micrometer-core"))
                                         .imports("io.micrometer.observation.Observation")
                                         .imports("io.micrometer.common.KeyValues")
                                         .imports("io.micrometer.core.instrument.Tag")
                                         .build();
 
                                 mi = autoFormat(
                                         template.apply(updateCursor(mi), mi.getCoordinates().replace(), parameters.toArray()),
-                                        executionContext
+                                        ctx
                                 );
                             }
                         }
-                        return super.visitMethodInvocation(mi, executionContext);
+                        return super.visitMethodInvocation(mi, ctx);
                     }
 
                 });

diff --git a/src/test/java/org/openrewrite/micrometer/UpgradeMicrometer.java b/src/test/java/org/openrewrite/micrometer/UpgradeMicrometer.java
@@ -44,7 +44,8 @@ class Dependencies {
         void maven() {
             rewriteRun(
               //language=xml
-              pomXml("""
+              pomXml(
+              """
                   <?xml version="1.0" encoding="UTF-8"?>
                   <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                     xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">