Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kotlinParserBuilder argument rather than new builder #713

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Jan 17, 2024

Resolves unused field warning.

Don't think this was intentional; functionally there should be no change as the builders are the same. At most we might see effects of the .clone(), which would be good to surface.

sourceFiles = Stream.concat(sourceFiles, processMainSources(mavenProject, javaParserBuilder.clone(), kotlinParserBuilder.clone(), rp, projectProvenance, alreadyParsed, ctx));
sourceFiles = Stream.concat(sourceFiles, processTestSources(mavenProject, javaParserBuilder.clone(), kotlinParserBuilder.clone(), rp, projectProvenance, alreadyParsed, ctx));

@timtebeek timtebeek self-assigned this Jan 17, 2024
@timtebeek timtebeek added the enhancement New feature or request label Jan 17, 2024
@timtebeek timtebeek merged commit d012e5f into main Jan 18, 2024
1 check passed
@timtebeek timtebeek deleted the use-ResourceParser.kotlinParserBuilder branch January 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants