Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support checking specified file content #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

bigplum
Copy link

@bigplum bigplum commented Feb 23, 2012

output_files
output_files_like
output_files_unlike
pre_remove_files
files_exist
files_not_exist

@PiotrSikora
Copy link
Contributor

  1. What is so specific about those features that they need to contain the "cache" keyword, couldn't you just call them "file" and "file_like"?

  2. It would be nice to have "exists" semantics so that one could verify when file is created or deleted.

@bigplum
Copy link
Author

bigplum commented Feb 23, 2012

  1. I dev "cache_file" for testing cache func of my module, so call it as "cache_file". You're right that call them "file" would be more accurate.

  2. Yes, It will be helpful.

@agentzh
Copy link
Member

agentzh commented Feb 24, 2012

Thank you for the work! I'll try merging this to master in the next week :)

@josegonzalez
Copy link

@agentzh ping :)

@agentzh
Copy link
Member

agentzh commented Dec 31, 2012

Hello!

On Sun, Dec 30, 2012 at 9:36 PM, Jose Diaz-Gonzalez <
[email protected]> wrote:

@agentzh https://github.com/agentzh ping :)

Sorry I haven't got the tuits to tweak and merge this patch yet :P I hope I
can look into this soon :)

Thank you for reminding me :)

Best regards,
-agentzh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants