Move luajit-specific elements to the end of state structs #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting prng and saved_jit_base in the middle of the struct messed with alignments on Armv7. Avoid the problem by moving the prng to the end so that the upstream hack of adding padding at the end works correctly. Fixes #106.
siddhesh
changed the title
|
This should fix all new failures in armv7 now. Introducing saved_jit_base and prng in the middle of the struct seemed to mess with the alignments of accesses of global_State, jit_State elements through gg_state as offset from its dispatch table. Putting the extension elements to the end fixes this. |
|
@siddhesh Merged. Thanks! |
|
@siddhesh Yeah, still one more failure as compared to the version before the merge. BTW, it'll also be great if you can have also have a look at those 2 original test failures on ARMv7. Thanks! |
|
Sorry, #107 should have been part of this, not sure how I missed it. I'll merge it in once Travis runs clean. |
|
The two failures look like qemu segfaults, so not related to luajit2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting prng and saved_jit_state in the middle of the struct messed with alignments on
Armv7. Avoid the problem by moving the luajit2-specific elements to the end.
Fixes #106.
It leaves just one new test failure introduced by the merge, which I will look at next.