-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incr method #11
base: master
Are you sure you want to change the base?
Incr method #11
Conversation
@splitice I can do the documentation if you do the tests ;) |
Haha, I would rather this not be the same as the incr method pull request from a year ago for the ngx-lua-module that's still pending due to me not having time to learn the test format and set up an environment for it. |
@splitice Heh, sorry about your pending PRs. Bug fixes usually take much higher priority than new features. But don't worry, I'll eventually clean up the pending PR list when I have a chance :) To assure you, those PRs are never forgotten. |
No need to worry, its not really a concern for me since we build our own repo anyway, just trying to open source what we can. This one here should be pretty easy 👍 I may also do flush_all from the TODO list in the future, I suspect we will need it down the line. |
@splitice Awesome! Thank you a lot for your contribution! |
@splitice BTW, I'll write up some tutorials on the test toolchain used here soon :) |
That would be great. I am in openresty-en so I'll keep an eye out. :) |
+1 |
Incr now respects expiration time. |
@splitice See https://openresty.gitbooks.io/programming-openresty/content/testing/index.html for the tutorial on the test toolchain. Let me know if there's anything missing. |
Sorry I dont currently have time to undertake that. Just moving some of the patches made in our private repo into the public forks. Anyone: feel free to undertake the test building. Submit a PR to my fork and I'll happily accept to forward onto this PR. |
any update on this PR ? |
Incrementing by value, defaults to 1. Happy to do the documentation if you do the tests :)