Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in resty.limit.req using ngx.shared.DICT.set_when #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hnakamur
Copy link

@hnakamur hnakamur commented Aug 7, 2019

This pull request fixes the race condition in resty.limit.req.

The following pull request must be merged before merging this pull request.

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-resty-core project.

@hnakamur hnakamur mentioned this pull request Aug 7, 2019
@hnakamur
Copy link
Author

Test passes with my pull request branches for lua-nginx-module and lua-resty-core.
https://travis-ci.org/hnakamur/lua-resty-limit-traffic/builds/576456344

Could you review this pull request?
Thanks!

@lkad
Copy link

lkad commented Oct 11, 2024

Test passes with my pull request branches for lua-nginx-module and lua-resty-core. https://travis-ci.org/hnakamur/lua-resty-limit-traffic/builds/576456344

Could you review this pull request? Thanks!

Hi @hnakamur,
I hope this message finds you well. I wanted to ask if you are currently using the changes from Pull Request in a production environment. Your insights would be greatly appreciated!
Thank you!

@hnakamur
Copy link
Author

Hi @lkad,
No, I'm not using the changes from the pull request in a produciton environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants