Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement knit_print methods for subclasses of SafetyWindow #816

Closed
Puzzled-Face opened this issue May 1, 2024 · 1 comment · Fixed by #820
Closed

Implement knit_print methods for subclasses of SafetyWindow #816

Puzzled-Face opened this issue May 1, 2024 · 1 comment · Fixed by #820
Assignees
@Puzzled-Face
Labels
enhancement New feature or request

Comments

@Puzzled-Face
Copy link
Collaborator

See #774 for details.

Blocks #814.
@Puzzled-Face Puzzled-Face added the enhancement New feature or request label May 1, 2024
@Puzzled-Face Puzzled-Face self-assigned this May 1, 2024
@Puzzled-Face Puzzled-Face mentioned this issue May 2, 2024
Closed
@Puzzled-Face
Copy link
Collaborator Author

Without a double line feed at the end of output created by knit_print, headings for subsequent report content are not formatted correctly. The presence of the double line feed is currently erratic. This PR will retro fit the needed code to knit_print methods that have been implemented for other classes.

This will generate a lot of changes in other helper_knit_print-XXXX.R files as well as in corresponding test snapshots and fixtures. All these changes will be minor.

@Puzzled-Face Puzzled-Face mentioned this issue May 2, 2024
Closed
@Puzzled-Face Puzzled-Face linked a pull request May 2, 2024 that will close this issue
816 implement knit print methods for subclasses of safetywindow #820
Merged
@Puzzled-Face Puzzled-Face mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Puzzled-Face Puzzled-Face

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

816 implement knit print methods for subclasses of safetywindow openpharma/crmPack
1 participant
@Puzzled-Face