Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement knit_print for subclasses of Design #814

Closed
Puzzled-Face opened this issue Apr 24, 2024 · 3 comments · Fixed by #823
Closed

Implement knit_print for subclasses of Design #814

Puzzled-Face opened this issue Apr 24, 2024 · 3 comments · Fixed by #823
Assignees
@Puzzled-Face
Labels
enhancement New feature or request

Comments

@Puzzled-Face
Copy link
Collaborator

See #774 for details.
@Puzzled-Face Puzzled-Face added the enhancement New feature or request label Apr 24, 2024
@Puzzled-Face Puzzled-Face self-assigned this Apr 24, 2024
@Puzzled-Face Puzzled-Face mentioned this issue May 1, 2024
Open
34 tasks
@Puzzled-Face
Copy link
Collaborator Author

Blocked by absence of knit_print methods for

  • subclasses of SafetyWindow
  • Effloglog
  • LogisticIndepBeta

@Puzzled-Face Puzzled-Face mentioned this issue May 1, 2024
Closed
@Puzzled-Face
Copy link
Collaborator Author

Puzzled-Face commented May 2, 2024 •
edited
Loading

Without a double line feed at the end of output created by knit_print, headings for subsequent report content are not formatted correctly. The presence of the double line feed is currently erratic. This PR will retro fit the needed code to knit_print methods that have been implemented for other classes.

This was actually done in #816.

@Puzzled-Face
Copy link
Collaborator Author

Puzzled-Face commented May 8, 2024 •
edited
Loading

This PR implements the tidy and knit_print methods for Model classes Effloglog and LogisticIndepBeta.

@Puzzled-Face Puzzled-Face mentioned this issue May 13, 2024
Merged
@Puzzled-Face Puzzled-Face linked a pull request May 13, 2024 that will close this issue
814 implement knit print for subclasses of design #823
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Puzzled-Face Puzzled-Face

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

814 implement knit print for subclasses of design openpharma/crmPack
1 participant
@Puzzled-Face