create a wrangler config file for the user in case one is not already present (alongside ways to opt out of this) #220
+147
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
dario-piotrowicz
force-pushed
the
dario/create-toml
branch
from
8c28c4f to
3f98f0e
Compare
🦋 Changeset detectedLatest commit: 470f24b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dario-piotrowicz
force-pushed
the
dario/create-toml
branch
from
3f98f0e to
1a43d87
Compare
vicb
reviewed
Jan 2, 2025
vicb
reviewed
Jan 2, 2025
vicb
reviewed
Jan 2, 2025
vicb
reviewed
Jan 2, 2025
…ready present remove unnecessary nullish operator
…ready present create a jsonc file instead of a toml one and check existence of any wrangler config file
…ready present add a comment for the cache kv binding
…ready present fix jsonc prettier formatting
…ready present fix broken logic and add way to opt out of wrangler config check
…ready present fix typo and update changeset
dario-piotrowicz
commented
Jan 2, 2025
…ready present update changeset
…ready present update changeset
…ready present update outdated code comment
…ready present update changeset
…ready present remove wrangler.jsonc problematic trailing commas
dario-piotrowicz
changed the title
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #193 I thought it'd be a nice touch if we created the
wrangler.tomlfile for the user instead of telling them to create and populate it themselves 🙂Related docs update: opennextjs/docs#45