Simplify and test container image names #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
=========================================
Coverage ? 70.85%
=========================================
Files ? 55
Lines ? 6855
Branches ? 0
=========================================
Hits ? 4857
Misses ? 1998
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally there was a lot of duplication between the general image name generation and the one that was "re-implemented" in the singularity runner. This refactoring simplifies that and re-uses the common implementation of container in the singularity class. Moreover, this simplification does away with the ugly
kwargsthat were added just to support custom implementations in the inheriting classes (as_docker was only ever used in calls to_container_image_nameas opposed toimage_name).