Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS #1450

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 5, 2025

I backport this for parity with 21.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348936 needs maintainer approval
  • JDK-8345728 needs maintainer approval

Issues

  • JDK-8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS (Bug - P3 - Approved)
  • JDK-8345728: [Accessibility,macOS,Screen Magnifier]: JCheckbox unchecked state does not magnify but works for checked state (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1450/head:pull/1450
$ git checkout pull/1450

Update a local copy of the PR:
$ git checkout pull/1450
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1450

View PR using the GUI difftool:
$ git pr show -t 1450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1450.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
8345728: [Accessibility,macOS,Screen Magnifier]: JCheckbox unchecked state does not magnify but works for checked state

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d29111a: 8348323: Corrupted timezone string in JVM crash log
  • ef282b7: 8180450: secondary_super_cache does not scale well

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1e87ff01994df16df7de331040fc5d7a4a85f630 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS Mar 5, 2025
@openjdk
Copy link

openjdk bot commented Mar 5, 2025

This backport pull request has now been updated with issues from the original commit.

@GoeLin GoeLin marked this pull request as ready for review March 8, 2025 21:06
@openjdk
Copy link

openjdk bot commented Mar 8, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Mar 8, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 10, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 86b0fb8.
Since your change was applied there have been 13 commits pushed to the master branch:

  • c46e81a: 8349751: AIX build failure after upgrade pipewire to 1.3.81
  • 43ac809: 8348600: Update PipeWire to 1.3.81
  • 11f9e7e: 8348299: Update List/ItemEventTest/ItemEventTest.java
  • 6cf39a7: 8341170: Open source several Choice related tests (part 2)
  • 94abc6a: 8341535: sun/awt/font/TestDevTransform.java fails with RuntimeException: Different rendering
  • 4c0117a: 8309841: Jarsigner should print a warning if an entry is removed
  • 38c5194: 8340560: Open Source several AWT/2D font and rendering tests
  • 20d5609: 8325435: [macos] Menu or JPopupMenu not closed when main window is resized
  • 9af7cbf: 8327071: [Testbug] g-tests for cgroup leave files in /tmp on linux
  • 071aaf8: 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/e48995f4997e08e50a0ed1781e1972dd5c303297...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@GoeLin Pushed as commit 86b0fb8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant