Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349751: AIX build failure after upgrade pipewire to 1.3.81 #1449

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 4, 2025

This is needed in 21 after the pipewire backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349751 needs maintainer approval

Issue

  • JDK-8349751: AIX build failure after upgrade pipewire to 1.3.81 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1449/head:pull/1449
$ git checkout pull/1449

Update a local copy of the PR:
$ git checkout pull/1449
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1449

View PR using the GUI difftool:
$ git pr show -t 1449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1449.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the base branch from master to pr/1448 March 4, 2025 19:22
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349751: AIX build failure after upgrade pipewire to 1.3.81

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 4, 2025

Hi @suchismith1993
could you please check that this works with the old AIX compiler?
We have a build with the new one, so that's checked.
Thanks!

@GoeLin GoeLin changed the title Goetz backport 8349751 Backport 19c0ce43e258d00d77314d76a361feb2069a5af1 Mar 4, 2025
@openjdk openjdk bot changed the title Backport 19c0ce43e258d00d77314d76a361feb2069a5af1 8349751: AIX build failure after upgrade pipewire to 1.3.81 Mar 4, 2025
@openjdk
Copy link

openjdk bot commented Mar 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Mar 4, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2025

Webrevs

@openjdk openjdk bot added approval and removed approval labels Mar 6, 2025
@GoeLin GoeLin changed the base branch from pr/1448 to master March 10, 2025 14:22
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit c46e81a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@GoeLin Pushed as commit c46e81a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8349751 branch March 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant