Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails #1441

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 1, 2025

Hi all,

This pull request contains a backport of commit a51e6699 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 5 Feb 2025 and was reviewed by Naoto Sato and Justin Lu.

Thanks!


Progress

  • JDK-8349200 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1441/head:pull/1441
$ git checkout pull/1441

Update a local copy of the PR:
$ git checkout pull/1441
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1441/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1441

View PR using the GUI difftool:
$ git pr show -t 1441

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1441.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 1, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
  • c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9d101b2528f4bb1c4dfb74cdc5e37343b9175580 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails Mar 1, 2025
@openjdk
Copy link

openjdk bot commented Mar 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 1, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the JMH test bug, no risk.

@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@sendaoYan
8349200: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 4, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 4, 2025

Going to push as commit 601e6f9.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
  • c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2025
@openjdk openjdk bot closed this Mar 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2025
@openjdk
Copy link

openjdk bot commented Mar 4, 2025

@sendaoYan Pushed as commit 601e6f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant