-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails #1441
8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails #1441
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport to fix the JMH test bug, no risk. |
@sendaoYan |
Thanks for the approved. /integrate |
Going to push as commit 601e6f9.
Your commit was automatically rebased without conflicts. |
@sendaoYan Pushed as commit 601e6f9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit a51e6699 from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 5 Feb 2025 and was reviewed by Naoto Sato and Justin Lu.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1441/head:pull/1441
$ git checkout pull/1441
Update a local copy of the PR:
$ git checkout pull/1441
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1441/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1441
View PR using the GUI difftool:
$ git pr show -t 1441
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1441.diff
Using Webrev
Link to Webrev Comment