Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix #1437

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 27, 2025

I backport this for parity with 21.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316497 needs maintainer approval

Issue

  • JDK-8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1437/head:pull/1437
$ git checkout pull/1437

Update a local copy of the PR:
$ git checkout pull/1437
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1437

View PR using the GUI difftool:
$ git pr show -t 1437

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1437.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
  • c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
  • 91457e6: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport dadd9cd1e8434cffaafc7406a864eaa55954cfb8 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix Feb 27, 2025
@openjdk
Copy link

openjdk bot commented Feb 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 27, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 3, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit 071aaf8.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 5480432: 8315876: Open source several Swing CSS related tests
  • d29111a: 8348323: Corrupted timezone string in JVM crash log
  • ef282b7: 8180450: secondary_super_cache does not scale well
  • e48995f: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11
  • 9d9bcd2: 8314840: 3 gc/epsilon tests ignore external vm options
  • 601e6f9: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails
  • ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
  • c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
  • 91457e6: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@GoeLin Pushed as commit 071aaf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant