Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348905: Add support to specify the JDK for compiling Jtreg tests #1375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 30, 2025

Hi all,

This pull request contains a backport of commit cbe9ec53 from the openjdk/jdk repository. This backport support set to an alternative JDK directory that is different from the JDK running the tests through JDK_FOR_COMPILE, shows as below command.

make test CONF=linux-x86_64-server-fastdebug TEST="jtreg:test/hotspot/jtreg/native_sanity/JniVersion.java" JDK_IMAGE_DIR=$PWD/build/linux-x86_64-server-fastdebug/images/jdk JDK_FOR_COMPILE=$PWD/build/linux-x86_64-server-release/images/jdk

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348905 needs maintainer approval

Issue

  • JDK-8348905: Add support to specify the JDK for compiling Jtreg tests (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1375/head:pull/1375
$ git checkout pull/1375

Update a local copy of the PR:
$ git checkout pull/1375
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1375

View PR using the GUI difftool:
$ git pr show -t 1375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1375.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport cbe9ec530fc248be74766ff6ff32761cd415a6f0 8348905: Add support to specify the JDK for compiling Jtreg tests Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport support set to an alternative JDK directory that is different from the JDK running the tests through JDK_FOR_COMPILE. Change has been verified locally, no risk.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@sendaoYan
8348905: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 30, 2025
@GoeLin
Copy link
Member

GoeLin commented Jan 31, 2025

Hi @sendaoYan
I think we should wait a bit with pushing this until the follow up issue is solved.

@sendaoYan
Copy link
Member Author

Hi @sendaoYan I think we should wait a bit with pushing this until the follow up issue is solved.

Okey.

@sendaoYan
Copy link
Member Author

/approval cancel

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@sendaoYan
8348905: The approval request has been cancelled successfully.

@openjdk openjdk bot removed the approval label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants