-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8348905: Add support to specify the JDK for compiling Jtreg tests #1375
base: master
Are you sure you want to change the base?
8348905: Add support to specify the JDK for compiling Jtreg tests #1375
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport support set to an alternative JDK directory that is different from the JDK running the tests through JDK_FOR_COMPILE. Change has been verified locally, no risk. |
@sendaoYan |
Hi @sendaoYan |
Okey. |
/approval cancel |
@sendaoYan |
Hi all,
This pull request contains a backport of commit cbe9ec53 from the openjdk/jdk repository. This backport support set to an alternative JDK directory that is different from the JDK running the tests through
JDK_FOR_COMPILE
, shows as below command.Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1375/head:pull/1375
$ git checkout pull/1375
Update a local copy of the PR:
$ git checkout pull/1375
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1375/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1375
View PR using the GUI difftool:
$ git pr show -t 1375
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1375.diff
Using Webrev
Link to Webrev Comment