Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320691: Timeout handler on Windows takes 2 hours to complete #1374

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 30, 2025

I backport this for parity with 21.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8320691 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8320691: Timeout handler on Windows takes 2 hours to complete (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1374/head:pull/1374
$ git checkout pull/1374

Update a local copy of the PR:
$ git checkout pull/1374
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1374

View PR using the GUI difftool:
$ git pr show -t 1374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1374.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320691: Timeout handler on Windows takes 2 hours to complete

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e1967d5: 8348625: [21u, 17u] Revert JDK-8185862 to restore old java.awt.headless behavior on Windows
  • b79136f: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
  • 95e4bc9: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4d50df63b6ea76fd6a6c387593c3d6bc9429007b 8320691: Timeout handler on Windows takes 2 hours to complete Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

This backport pull request has now been updated with issue from the original commit.

@GoeLin GoeLin marked this pull request as ready for review January 30, 2025 14:14
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 31, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Feb 5, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 5, 2025

Going to push as commit 69e8c20.
Since your change was applied there have been 4 commits pushed to the master branch:

  • d2cbada: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04
  • e1967d5: 8348625: [21u, 17u] Revert JDK-8185862 to restore old java.awt.headless behavior on Windows
  • b79136f: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
  • 95e4bc9: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 5, 2025
@openjdk openjdk bot closed this Feb 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2025
@openjdk
Copy link

openjdk bot commented Feb 5, 2025

@GoeLin Pushed as commit 69e8c20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant