Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321512: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails on 32-bit platforms #1363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Jan 27, 2025

A clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321512 needs maintainer approval

Issue

  • JDK-8321512: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails on 32-bit platforms (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1363/head:pull/1363
$ git checkout pull/1363

Update a local copy of the PR:
$ git checkout pull/1363
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1363/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1363

View PR using the GUI difftool:
$ git pr show -t 1363

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1363.diff

Using Webrev

Link to Webrev Comment

…java fails on 32-bit platforms

Reviewed-by: shade, iwalulya
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8c003d83c450a1e706ec5e5ba3d319d84fc4b584 8321512: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java fails on 32-bit platforms Jan 27, 2025
@openjdk
Copy link

openjdk bot commented Jan 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant