8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis #1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean backport of JDK-8348562. The crashes can be reproduced in 21u by
make run-test TEST="jdk/jfr/api/consumer/streaming/TestFilledChunks.java" JTREG="VM_OPTIONS=-XX:+UseZGC -XX:+ZGenerational"
on linux PPC64le. The fix only adds a null check + bailout where the current implementation crashes with SIGSEGV. The test passes with this fix.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1361/head:pull/1361
$ git checkout pull/1361
Update a local copy of the PR:
$ git checkout pull/1361
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1361/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1361
View PR using the GUI difftool:
$ git pr show -t 1361
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1361.diff
Using Webrev
Link to Webrev Comment