Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis #1361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jan 27, 2025

Clean backport of JDK-8348562. The crashes can be reproduced in 21u by make run-test TEST="jdk/jfr/api/consumer/streaming/TestFilledChunks.java" JTREG="VM_OPTIONS=-XX:+UseZGC -XX:+ZGenerational" on linux PPC64le. The fix only adds a null check + bailout where the current implementation crashes with SIGSEGV. The test passes with this fix.


Progress

  • JDK-8348562 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1361/head:pull/1361
$ git checkout pull/1361

Update a local copy of the PR:
$ git checkout pull/1361
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1361

View PR using the GUI difftool:
$ git pr show -t 1361

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1361.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport afcc2b03afc77f730300e1d92471466d56ed75fb 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis Jan 27, 2025
@openjdk
Copy link

openjdk bot commented Jan 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant