Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347965: (tz) Update Timezone Data to 2025a #3245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RadekCap
Copy link
Contributor

@RadekCap RadekCap commented Jan 27, 2025

Backport of https://bugs.openjdk.org/browse/JDK-8347965
Changes to Update Timezone Data to 2025a

Passed tier1 tests.
Passed gtests.

Results of
make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/java/text/Format                     111   111     0     0   
   jtreg:test/jdk/java/util/TimeZone                    25    25     0     0   
   jtreg:test/jdk/sun/util/calendar                      5     5     0     0   
   jtreg:test/jdk/sun/util/resources                    22    22     0     0   
==============================
TEST SUCCESS

Finished building target 'run-test' in configuration 'linux-x86_64-server-release'

Progress

  • Change must not contain extraneous whitespace
  • JDK-8347965 needs maintainer approval
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

  • JDK-8347965: (tz) Update Timezone Data to 2025a (Enhancement - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3245/head:pull/3245
$ git checkout pull/3245

Update a local copy of the PR:
$ git checkout pull/3245
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3245

View PR using the GUI difftool:
$ git pr show -t 3245

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3245.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

⚠️ @RadekCap the commit e8263077e0e36bfd70c3764489434f60c9b7148d does not refer to an issue in project JDK.

@RadekCap RadekCap marked this pull request as draft January 27, 2025 15:15
@gnu-andrew
Copy link
Member

You can't use a commit ID from a PR, only from integrated commits. Using the original trunk commit ID (caa3c78f7837b1f561740184bd8f9cb671c467eb) should be fine.

@RadekCap RadekCap changed the title Backport e8263077e0e36bfd70c3764489434f60c9b7148d Backport 5d21a2bcc4ba06331df52470795134d8540dd567 Jan 28, 2025
@RadekCap RadekCap marked this pull request as ready for review January 28, 2025 11:46
@openjdk openjdk bot changed the title Backport 5d21a2bcc4ba06331df52470795134d8540dd567 8347965: (tz) Update Timezone Data to 2025a Jan 28, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 28, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2025

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jan 29, 2025

Hi @RadekCap,
did you run the TimeZone tests? Alternatively, did you check they are included in tier1?

Please fix the comment above which states that the backport is clean.

I verified the changes are the same changes as in 21 and head but applied to the other paths.

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@RadekCap
Copy link
Contributor Author

A clean backport comment was removed.

I've run the tests mentioned in the first comment that recommended me to run when I'm updating tz data. Should I run any other? Please let me know.

@RadekCap
Copy link
Contributor Author

/approval request backport of (tz) Update Timezone Data to 2025a, updating tz data to the latest version, medium risk, jtregs tier1 are passing, "jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources" are passing as well

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@RadekCap
8347965: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 29, 2025
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch itself is clean compared to 21u.
I don't see an answer on whether the java/time tests were run? These are not part of tier 1.

@gnu-andrew
Copy link
Member

/reviewers 2 reviewer

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@gnu-andrew
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants