-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347965: (tz) Update Timezone Data to 2025a #3245
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
You can't use a commit ID from a PR, only from integrated commits. Using the original trunk commit ID (caa3c78f7837b1f561740184bd8f9cb671c467eb) should be fine. |
This backport pull request has now been updated with issue from the original commit. |
Hi @RadekCap, Please fix the comment above which states that the backport is clean. I verified the changes are the same changes as in 21 and head but applied to the other paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
A clean backport comment was removed. I've run the tests mentioned in the first comment that recommended me to run when I'm updating tz data. Should I run any other? Please let me know. |
/approval request backport of (tz) Update Timezone Data to 2025a, updating tz data to the latest version, medium risk, jtregs tier1 are passing, "jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources" are passing as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch itself is clean compared to 21u.
I don't see an answer on whether the java/time tests were run? These are not part of tier 1.
/reviewers 2 reviewer |
@gnu-andrew |
Backport of https://bugs.openjdk.org/browse/JDK-8347965
Changes to Update Timezone Data to 2025a
Passed tier1 tests.
Passed gtests.
Results of
make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3245/head:pull/3245
$ git checkout pull/3245
Update a local copy of the PR:
$ git checkout pull/3245
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3245/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3245
View PR using the GUI difftool:
$ git pr show -t 3245
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3245.diff
Using Webrev
Link to Webrev Comment