Selected tab is stored in the route #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Rodri77
commented
Oct 31, 2024
Rodri77
commented
- selected tab comes from route, so reload keeps the current tab.
- Update connect button when there are no connections so it redirects to the add connections tab.
- Fix warning for missing key.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pellicceama
reviewed
Oct 31, 2024
added 7 commits
November 1, 2024 19:46
tonyxiao
approved these changes
Nov 4, 2024
| @@ -41,6 +47,14 @@ export function ConnectionPortal({className}: ConnectionPortalProps) { | |||
| }, | |||
| }) | |||
|
|
|||
| const navigateToTab = (tab: string) => { | |||
There was a problem hiding this comment.
I'd use this library rather than re-inventing the wheel ourselves here. https://www.npmjs.com/package/next-usequerystate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.