oas types

[pellicceama]

Important

Type casting adjustments in appRouter.ts and createRouterHandler.ts to use any for router-related functions.

• Type Casting:
  • In appRouter.ts, cast appRouter to any in generateOpenApiDocument().
  • In createRouterHandler.ts, cast router to any in createOpenApiFetchHandler().
• Misc:
  • Remove unused import of AppRouter in createRouterHandler.ts.

^{This description was created by for 0f2f3e3. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
openint	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 18, 2025 5:07pm

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 0f2f3e3 in 1 minute and 23 seconds

More details

• Looked at 34 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. packages/api/appRouter.ts:121

• Draft comment:
  Avoid casting appRouter to any; use proper type to preserve type safety.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 30% vs. threshold = 50%
  The use of as any is a type assertion that bypasses TypeScript's type checking. While generally it's good practice to avoid any, in this case we're dealing with a third-party library function. The author might have used as any because of compatibility issues with the library's type definitions. Without knowing the exact type signature of generateOpenApiDocument, changing to as AppRouter could potentially cause type errors.
  I might be too cautious - using as AppRouter could provide better type safety if the function is designed to work with tRPC routers. The current code is unnecessarily bypassing all type checking.
  However, the fact that the author specifically chose to use as any suggests they might have encountered type compatibility issues. Making this change could break the build if the library's types don't align perfectly with AppRouter.
  While the suggestion promotes better type safety, we don't have enough context about the library's type requirements to be confident this change won't cause issues.

2. packages/api/createRouterHandler.ts:312

• Draft comment:
  Avoid using 'any' for router; consider using a proper type (e.g., AppRouter) for better type safety.
• Reason this comment was not posted:
  Marked as duplicate.

3. packages/api/appRouter.ts:121

• Draft comment:
  Avoid casting appRouter to 'any'; this bypasses type safety. Instead, update generateOpenApiDocument or router types to properly accept AppRouter.
• Reason this comment was not posted:
  Marked as duplicate.

4. packages/api/createRouterHandler.ts:312

• Draft comment:
  Casting router to 'any' in createOpenApiFetchHandler weakens type safety. Use a more specific type to ensure correctness.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_VkFPImApmA1fDfEH

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[recurseml]

✨ No issues found! Your code is sparkling clean! ✨