Google FS API New #234
Draft
Google FS API New #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API modified: apps/web/app/api/debug/route.ts modified: connectors/connector-google/server.ts modified: kits/sdk/openapi.json modified: kits/sdk/openapi.types.d.ts modified: packages/api/createRouterHandler.ts modified: packages/api/package.json modified: packages/api/proxyHandler.ts modified: packages/engine-backend/context.ts modified: packages/trpc/package.json modified: pnpm-lock.yaml modified: unified/unified-file-storage/adapters/index.ts modified: unified/unified-file-storage/adapters/sharepoint-adapter/index.ts modified: unified/unified-file-storage/adapters/sharepoint-adapter/mappers.ts new file: unified/unified-file-storage/generate.cjs modified: unified/unified-file-storage/package.json modified: unified/unified-file-storage/router.spec.ts modified: unified/unified-file-storage/router.ts modified: unified/unified-file-storage/unifiedModels.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to bb215af in 2 minutes and 30 seconds
More details
- Looked at
2125lines of code in23files - Skipped
1files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. unified/unified-file-storage/adapters/google-adapter/index.ts:91
- Draft comment:
ThelistDriveGroupsfunction is returning an empty list of items. It should map the response data to the unified DriveGroup model using the mappers, similar to how it's done inlistFiles. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The fact that listDrives also returns an empty list suggests this may be intentional behavior. Without seeing the requirements or understanding the Google Drive API capabilities around drive groups, I can't be certain if this is a bug or intended behavior. The comment makes assumptions about how it should work without clear evidence.
I could be wrong about the intentionality - maybe both functions are incorrectly implemented. Also, the similarity to listDrives might not be relevant if they serve different purposes.
While both functions could be wrong, without clear requirements or API documentation showing that drive groups should exist and be mappable, keeping a speculative comment would violate the rule about needing strong evidence.
Delete the comment since we don't have strong evidence that returning an empty list is incorrect behavior for drive groups.
2. unified/unified-file-storage/adapters/sharepoint-adapter/index.ts:284
- Draft comment:
ThelistFilesfunction throws an error ifinput.cursoris provided without adrive_id. Consider allowing pagination without adrive_id. - Reason this comment was not posted:
Confidence changes required:50%
ThelistFilesfunction in the SharePoint adapter has a potential issue with pagination. It throws an error ifinput.cursoris provided without adrive_id, which might not be necessary. Consider allowing pagination without adrive_id.
3. unified/unified-file-storage/adapters/sharepoint-adapter/index.ts:125
- Draft comment:
ThedownloadFileByIdfunction does not handle the case wheredownloadResponse.bodyis null. Ensure to handle this case to avoid unexpected behavior. - Reason this comment was not posted:
Comment did not seem useful.
4. unified/unified-file-storage/adapters/google-adapter/index.ts:70
- Draft comment:
ThedownloadFileByIdfunction does not handle the case whereres.response.bodyis null. Ensure to handle this case to avoid unexpected behavior. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_7auvKDXx0m7B6Vjq
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| throw new TRPCError({code: 'NOT_FOUND', message: 'No drives found'}) | ||
| } | ||
|
|
||
| return { |
There was a problem hiding this comment.
The listDrives function is returning an empty list of items. It should map the response data to the unified Drive model using the mappers, similar to how it's done in listFiles.
openint-bot
approved these changes
Jan 26, 2025
| @@ -147,3 +148,11 @@ jobs: | |||
| git fetch origin main | |||
| git checkout main | |||
| git push origin main:production -f | |||
| - name: Wait for 5 minutes for any remaining Vercel Main Branch Deployment that's in flight | |||
There was a problem hiding this comment.
Our deployment is not guaranteed to take 5 mins. Could be longer sometimes
| @@ -1,123 +1,8 @@ | |||
| // import {clerkClient} from '@clerk/nextjs/server' | |||
| @@ -6,7 +6,8 @@ | |||
| "dependencies": { | |||
| "@openint/cdk": "workspace:*", | |||
| "@openint/util": "workspace:*", | |||
| "@opensdks/runtime": "^0.0.19" | |||
| "@opensdks/runtime": "^0.0.19", | |||
| "@opensdks/sdk-google": "*" | |||
There was a problem hiding this comment.
hmm we should probably version this at least with ^...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Introduces Google File Storage API integration with listing, downloading, and exporting capabilities, enhances SharePoint adapter, and adds comprehensive tests.
googleAdapteringoogle-adapter/index.tsfor listing, downloading, and exporting files.downloadFileByIdfor Google Drive ingoogle-adapter/index.ts.google-adapter/mapper.ts.sharepoint-adapter/index.tsto improve file retrieval and downloading.downloadFileByIdfor SharePoint insharepoint-adapter/index.ts.sharepoint-adapter/mappers.ts.fileStorageRouterinrouter.tsto include new endpoints for Google and SharePoint.createRouterHandler.tsto handle new API routes.proxyHandler.tsto support new proxy logic.router.spec.tsfor Google and SharePoint functionalities.package.jsonfiles for new SDKs and tools.This description was created by
for bb215af. It will automatically update as commits are pushed.