WIP: Make code centralization and lint image update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the CFT lint image with the helper functions previously saved as `test/make.sh` in every module. These helper functions are being centralized within the image to reduce code duplication across the modules. The file has been named to `task_helper_functions.sh` to indicate that these helper functions are available for module tasks regardless of whether those tasks are called from `make` or not. The commit also upgrades the version of Terraform to 0.12.4 and bumps the minor version of the lint image to accommodate the change.
This commit takes the helper functions from the `test/make.sh` file that is included in most CFT modules and incorporates them into the Lint image for the purpose of centralizing that code and reducing duplication. The `make.sh` file containing the helper functions has been renamed go `task_helper_functions.sh` to indicate that the functions are independent from `make`, and each helper function has its own wrapper script that will source `task_helper_functions.sh` and call the function directly (with arguments handled as-necessary). Finally, the Docker image has been modified to pull in all necessary files and $PATH has been modified to accommodate the wrapper scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the work being performed to centralize all the helper functions from
test/make.shin the CFT modules and ensure that code is available on the CFT lint Docker image. This PR is mainly for visibility - I don't imagine we want to merge into this fork's master branch.