Update the ASP.NET Core/OWIN integrations to allow returning authentication tickets with a null or empty principal #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation tickets with a null or empty principal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a null authentication ticket (or an
AuthenticateResult.NoResult()result for ASP.NET Core) is returned by the ASP.NET Core and OWIN hosts when no "main principal" can be found based on the request type and grant type.Sadly, this logic makes advanced scenarios like custom grant types that need to validate incoming tokens (e.g a grant type that accepts an access token parameter) harder to implement, as
AuthenticateAsync(...)doesn't return anything useful in 5.0 (in 4.0, callingAuthenticateAsync()for custom grant types wasn't supported).This PR changes that by returning an authentication ticket with an empty/null principal and a non-empty
AuthenticationPropertiesthat can be used to access the other types of validated tokens.