-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused examples / unused tests / unused diagrams #354
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not ok removing these without adding a URL or something to the conformance tests or something equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to add a link to conformance tests and have done so, thanks!
Just to clarify (and I've updated the main description of the PR to say this now), these tests test the examples in the specification against a schema that's not up to date, so the tests fails. Keeping an incorrect & unmaintained schema in the repo is just very unhelpful to anyone looking at the repo.
I'm making no judgement on the value of these things and would be very happy if someone wants to raise a new PR that puts back / updates the schema and adds running the tests into the GitHub actions.