Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused examples / unused tests / unused diagrams #354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,32 +4,18 @@

The current WG-Draft version is built automatically from the master branch and can be accessed at: https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html

### Running Tests ###
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not ok removing these without adding a URL or something to the conformance tests or something equivalent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to add a link to conformance tests and have done so, thanks!

Just to clarify (and I've updated the main description of the PR to say this now), these tests test the examples in the specification against a schema that's not up to date, so the tests fails. Keeping an incorrect & unmaintained schema in the repo is just very unhelpful to anyone looking at the repo.

I'm making no judgement on the value of these things and would be very happy if someone wants to raise a new PR that puts back / updates the schema and adds running the tests into the GitHub actions.

This repository contains examples from the specifications and the JSON
schema definitions extracted as separate files in the directories
`examples` and `schema`, respectively. The directory `tests` contains
tests (written in python) that check if the examples comply to the
schema files.

To run the tests, follow these instructions:

* Build the test command using docker:
### Building the HTML

```
docker build -t openid.net/tests-oidc4vp tests
docker run -v `pwd`:/data danielfett/markdown2rfc openid-4-verifiable-presentations-1_0.md
```

* Run the tests:
### Conformance tests

```
docker run -v `pwd`:/data openid.net/tests-oidc4vp
```
Conformance tests are available for testing whether both Wallets and
Verifiers are compliant with this specification, see:

### Building the HTML

```
docker run -v `pwd`:/data danielfett/markdown2rfc openid-4-verifiable-presentations-1_0.md
```
https://openid.net/certification/conformance-testing-for-openid-for-verifiable-presentations/

### Contribution guidelines ###

Expand Down
38 changes: 0 additions & 38 deletions diagrams/presentation.plantuml

This file was deleted.

43 changes: 0 additions & 43 deletions diagrams/presentation_cross_device.plantuml

This file was deleted.

44 changes: 0 additions & 44 deletions diagrams/request_uri_mode_post.md

This file was deleted.

53 changes: 0 additions & 53 deletions diagrams/request_uri_mode_post_through_browser_api.md

This file was deleted.

53 changes: 0 additions & 53 deletions diagrams/request_uri_mode_post_through_browser_api.plantuml

This file was deleted.

53 changes: 0 additions & 53 deletions diagrams/signed_request_uri_through_browser_api.plantuml

This file was deleted.

12 changes: 0 additions & 12 deletions diagrams/verifiable_credential_presentation.plantuml

This file was deleted.

Binary file removed diagrams/verifiable_credential_presentation.png
Binary file not shown.

This file was deleted.

Binary file not shown.
22 changes: 0 additions & 22 deletions examples/client_metadata/client_client_id_did.json

This file was deleted.

Loading
Loading