Move Proof Types from Credential Endpoint section to an appendix #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a quick reminder before I forget: This will very likely shift references from HAIP (and maybe also OpenID4VP) -> when this gets merged, we should check and fix those if necessary. |
|
You're right Christian. given that, is this worth the change..? |
|
I like the change - I think it improves readability. I can make the fixes after this merge in both specs and just wanted to make sure we don't forget |
c2bo
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
I think this is self-explanatory. I chose to move it before the Key Attestation and Wallet Attestation parts as they refer to Proof Types so it felt more intuitive. I hope that's okay.