-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Credential Offer Flow for Authorized Code Flow in the introduction #115
Conversation
…n Code Flow Introduction and added use case example for Wallet-initiated flow. minor improvements on Section 3.4 and 3.5
Co-authored-by: Tobias Looker <[email protected]>
Co-authored-by: Tobias Looker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulbastian thank you very much, you saved to me a consistent amount of work with this PR
Co-authored-by: Giuseppe De Marco <[email protected]>
All comments resolved, ready for merge @Sakurann @tlodderstedt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good but I found quite some issues. I will approve ones my comments have been addressed/resolved.
Co-authored-by: Judith <[email protected]>
…nID4VCI into credential_offer_flow
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
Co-authored-by: Judith <[email protected]>
all issues resolved except for one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final, minor comment on describing End-User authentication in the flow. I approve already because it's a subtle change.
also adding use case example for Wallet-initiated flow and some minor improvements to the sequence diagrams
Closes #76