Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Credential Offer Flow for Authorized Code Flow in the introduction #115

Merged
merged 39 commits into from
Dec 14, 2023

Conversation

paulbastian
Copy link
Contributor

@paulbastian paulbastian commented Nov 16, 2023

also adding use case example for Wallet-initiated flow and some minor improvements to the sequence diagrams

Closes #76

…n Code Flow Introduction and added use case example for Wallet-initiated flow. minor improvements on Section 3.4 and 3.5
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulbastian thank you very much, you saved to me a consistent amount of work with this PR

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
Co-authored-by: Giuseppe De Marco <[email protected]>
@paulbastian
Copy link
Contributor Author

All comments resolved, ready for merge @Sakurann @tlodderstedt

Copy link
Contributor

@ju-cu ju-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good but I found quite some issues. I will approve ones my comments have been addressed/resolved.

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
tlodderstedt and others added 16 commits December 13, 2023 13:08
@paulbastian paulbastian requested a review from ju-cu December 13, 2023 12:26
@paulbastian
Copy link
Contributor Author

all issues resolved except for one.
@ju-cu please review

Copy link
Contributor

@ju-cu ju-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final, minor comment on describing End-User authentication in the flow. I approve already because it's a subtle change.

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
@Sakurann Sakurann merged commit 103b707 into main Dec 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for credential offer initated Authorization Code to Section 3
8 participants