Skip to content

Commit

Permalink
Wallet notifying the Issuer of (un)successful issuance of credential(…
Browse files Browse the repository at this point in the history
…s) (#70)

7 approvals. No objection to merge during the DCP WG call. open for more than a week.

* migrate PR608 from bitbucket

* Apply suggestions from code review

Co-authored-by: Giuseppe De Marco <[email protected]>

* modify issuer_state

* Apply suggestions from Giuseppe's code review

Co-authored-by: Giuseppe De Marco <[email protected]>

* Apply suggestions from Giuseppe's code review

* add callback_id

* align batch to credential endpoint

* Apply suggestions from code review

* Revert "modify issuer_state"

This reverts commit 0f50200.

* typo

Co-authored-by: Joseph Heenan <[email protected]>

* remove issuer_state

* change status values to success, failure and rejected

* callback endpoint is protected by the AT

* Cla

* add section on successful and error responses

* typos

* capitalize Credential

Co-authored-by: Giuseppe De Marco <[email protected]>

* removing media type requirements

* clarify three `status` values

* change example to 204 No Content

* clean-up of the intro text

* updating example to be access token authentication

* Apply wording based on the suggestions from code review

* draft PR on how callback_session could work

* Revert "draft PR on how callback_session could work"

This reverts commit 8d45c70.

* replace callback with acknowledgement

* removes a surplus `

Co-authored-by: Daniel Fett <[email protected]>

* clean up

* Apply suggestions from code review

Co-authored-by: Torsten Lodderstedt <[email protected]>
Co-authored-by: David Chadwick <[email protected]>

* Apply suggestions from code review

Co-authored-by: David Chadwick <[email protected]>
Co-authored-by: Daniel Fett <[email protected]>

* fix error message

* change to delete signal and make this endpoint optional to the wallet

* Apply suggestions from Torsten's code review

Co-authored-by: Torsten Lodderstedt <[email protected]>

* rename issuer metadata to ack_endpoint

* clarify error behavior

Co-authored-by: David Chadwick <[email protected]>

* fix references

* change from acknowledgement to notification

* editorial

* The Wallet MUST send one Notification Request per Credential issued

* update language

* Update openid-4-verifiable-credential-issuance-1_0.md

Co-authored-by: Kristina <[email protected]>

* Update openid-4-verifiable-credential-issuance-1_0.md

Co-authored-by: Daniel Fett <[email protected]>

* Apply suggestions from code review

* add document history

* fix typo to make file compile

* Apply suggestions from code review

Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Torsten Lodderstedt <[email protected]>

* Apply suggestions from code review

* networking error can cause request not received

* clarify this endpoint is optional for the wallet

---------

Co-authored-by: Kristina <=>
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Joseph Heenan <[email protected]>
Co-authored-by: Daniel Fett <[email protected]>
Co-authored-by: Torsten Lodderstedt <[email protected]>
Co-authored-by: David Chadwick <[email protected]>
Co-authored-by: Tobias Looker <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
  • Loading branch information
8 people authored Dec 22, 2023
1 parent 12d5ede commit 7210c6b
Showing 1 changed file with 134 additions and 36 deletions.
Loading

0 comments on commit 7210c6b

Please sign in to comment.