[ephemeris] Add option for disabling the cache #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching. This in interesting especially when defining/debugging these files. Signed-off-by: Gaël L'hopital <[email protected]>
|
The caching behaviour has been identified as a source of problems many times in the forum. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Gaël L'hopital <[email protected]>
|
It would be nicer if it would monitor changes to the file instead (e.g. using the |
|
That was my first thought but I though this could be a first easy step. I blocked myself because ephemeris does not have a dedicated folder for user defined files, so they can be anywhere but I'll have a look at WatchService also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds possibility to disable user defined holiday description files caching.
This in interesting especially when defining/debugging these files.
A new option can be set in the ephemeris.cfg file,
cache=true/false.Default value is true, so no breaking change if the option is absent.