[unifi] Make request timeout configurable to deal with slower devices like Unifi Express #18349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arne Seime <[email protected]>
Signed-off-by: Arne Seime <[email protected]>
lsiepel
approved these changes
Mar 2, 2025
lsiepel
added
the
enhancement
jlaur
requested changes
Mar 2, 2025
Comment on lines
+95
to
+97
| public boolean isUnifios() { | ||
| return unifios; | ||
| } |
There was a problem hiding this comment.
Duplicated, see lines 103-105.
Comment on lines
+99
to
+101
| public void setUnifios(boolean unifios) { | ||
| this.unifios = unifios; | ||
| } |
There was a problem hiding this comment.
Duplicated, see lines 107-109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make request timeout configurable, default is unchanged at 5 seconds.
Necessary to deal wtih slower controllers like Unifi Express which frequently times out with the default value.