-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unifi] Add network thing #18335
base: main
Are you sure you want to change the base?
[unifi] Add network thing #18335
Conversation
Signed-off-by: Thomas Lauterbach <[email protected]>
Signed-off-by: Thomas Lauterbach <[email protected]>
Oh, I forgot to mention that I haven't updated the README yet. I'd rather get some feedback on Know Issue 2. I would understand if you don't want to merge this PR because of that. Therefore I will just wait until I get some feedback here before I continue with documentation. |
Signed-off-by: Thomas Lauterbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I plan to give this a test run and will then resume the review and try to provide some feedback to your concerns.
...ding.unifi/src/main/java/org/openhab/binding/unifi/internal/api/cache/UniFiNetworkCache.java
Outdated
Show resolved
Hide resolved
...ding.unifi/src/main/java/org/openhab/binding/unifi/internal/api/cache/UniFiNetworkCache.java
Outdated
Show resolved
Hide resolved
...i/src/main/java/org/openhab/binding/unifi/internal/api/util/UniFiNetworkInstanceCreator.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.unifi/src/main/resources/OH-INF/i18n/unifi.properties
Outdated
Show resolved
Hide resolved
...unifi/src/main/java/org/openhab/binding/unifi/internal/handler/UniFiNetworkThingHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Lauterbach <[email protected]>
In my setup I have
That's a bit strange. What happens if you disable a network from the web interface and check the app, or vice versa? Unfortunately I won't be popular if I start testing this right now. 😉 |
Actually for some reason I cannot pause the networks right now, neither from the web interface nor via API. I don't know why, maybe Ubiquiti broke this in the last release? |
Aaah now I remember: there is a long open bug that prevents networks from being paused when DHCP guarding is activated (see: https://community.ui.com/questions/Failed-to-pause-network/e23ca7d2-36cf-495d-ae0e-a0677a24cbe3#answer/e71b475a-c869-45f0-8586-bfb7a0550445) With DHCP guarding disabled I can stop the network in the UI and this is correctly reflected in OH. |
Just checked again the other way round: I disabled a network via openHAB and checked the official apps: In the iOS app everything is working as expected. The network is displayed as paused and can be enabled there. The web UI is however still broken: the network is shown as disabled (greyed out) but when you click manage there is still the "pause" button although there should be the "continue" button instead. |
Enabling the network via openHAB is not reflected in the official apps at all. |
Add network thing to binding
The binding currently allows to disable WiFi networks which is handy when you want to stop certain wireless clients to use the network. However there are two cases where you actually might want to control the underlying network instead:
Description
This PR will add a new network thing to the binding which will be auto discovered. Networks can be disabled/enabled and offer channels for the site, the number of connected clients and the network purpose.
Known Issues: