Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[casokitchen] Initial contribution #18243

Merged
merged 19 commits into from
Feb 28, 2025
Merged

[casokitchen] Initial contribution #18243

merged 19 commits into from
Feb 28, 2025

Conversation

weymann
Copy link
Contributor

@weymann weymann commented Feb 9, 2025

Binding to connect CASO Smart Kitchen devices.

Currently wine coolers are supported, development team told me more devices will follow.
Topic was discussed in forum and binding is present on Marketplace.

@weymann weymann requested a review from a team as a code owner February 9, 2025 17:30
@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Feb 10, 2025
@lsiepel

This comment was marked as outdated.

Sign in to view
lsiepel
lsiepel requested changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Looked at all the files and left some comments. Let me know when you are ready.

lsiepel
lsiepel requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments left. Otherwise LGTM

@jlaur
Copy link
Contributor

jlaur commented Feb 27, 2025

Spotless must be applied after #18318.

weymann added 19 commits February 28, 2025 11:01
@weymann
initial commit
f66de7c 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
channel descriptions
f32c867 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
channel descriptions
bf41729 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
status updates
21eac1b 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add translations
4d8888b 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
bugfix utc conversion
f0d2f47 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
quick refresh
5bdd3f2 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
datetime correction
7a92c06 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
http request timeout to 60 secs
0c8a8c5 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
prepare release version
31ff082 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
prepare release version
f2b794f 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
5.0..0 preparation
fa90063 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
light update policy veto
e148486 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
remove refreshInterval advanced parameter
4780737 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
pom and codeowners
6f55251 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
solve review comments
60153d1 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
header fix
68ebbd9 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
add tags
cbc3bbc 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann
spotless
fdb9494 
Signed-off-by: Bernd Weymann <[email protected]>
@weymann weymann force-pushed the feature/casokitchen branch from 7c4494b to fdb9494 Compare February 28, 2025 10:12
lsiepel
lsiepel approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Now, you could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

@lsiepel lsiepel merged commit efc103c into openhab:main Feb 28, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Feb 28, 2025
@holgerfriedrich
Copy link
Member

This seems to cause unstable build on CI

grafik

Maybe you could have a look at the test? Thanks!

@jlaur jlaur mentioned this pull request Mar 2, 2025
Merged
@jlaur
Copy link
Contributor

jlaur commented Mar 2, 2025

Maybe you could have a look at the test?

See #18346. It would still be good to have a look, since @weymann probably had an intention with the test code being removed. Nevertheless, I will merge that now to fix the builds, and it can be added back when stabilized.

@holgerfriedrich
Copy link
Member

Thanks, @jlaur. Sorry, I did not see this PR. I got merged 2 mins ago 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@weymann @lsiepel @jlaur @holgerfriedrich