Split Build Steps for PG into seperate files. macOS / VS now should be easily built #450
Conversation
frontend/package.json
Outdated
| "dist": "electron-builder", | ||
| "dist:mac:x64": "NODE_ENV=production electron-builder --mac --x64 ", | ||
| "dist:mac:arm64": "NODE_ENV=production electron-builder --mac --arm64", | ||
| "dist:mac:universal": "NODE_ENV=production electron-builder --mac --universal", |
There was a problem hiding this comment.
just a heads up - this link from build:macos is super important:
--arch=universal --osxUniversal.x64ArchFiles=Contents/Resources/app/app/projectGenerator",
otherwise universal PG won't work.
There was a problem hiding this comment.
Amazing yeah was some issues with that! Updated now and all seems to be working on both platforms
|
Okay this is looking good! Just need to test the CI upload really now! I've manually added them here: |
|
@ofTheo could you make a bleeding branch on the PG repo and i'll also PR to that and see how it goes with ci |
|
@danoli3 just added - https://github.com/openframeworks/projectGenerator/releases/tag/bleeding |
Workflow test via Bleeding merge
CI PG Test Build
CI Bleeding Test
CI PG macOS Test Upload
CI Workflow Fixes Bleeding Test
CI Bleeding macOS fix
CI macOS final
CI macOS PG Ci Test
CI macOS final fix
|
Okay sweet that's all building and deploying via the auto bots
|
| "dist": "electron-builder", | ||
| "dist:mac:x64": " electron-builder --mac --x64 --publish never", | ||
| "dist:mac:arm64": " electron-builder --mac --arm64 --publish never", | ||
| "dist:mac:universal": " electron-builder --mac --universal --publish never", |
There was a problem hiding this comment.
does this in turn call build:mac below ?
is that where the:
"mergeASARs": false,
"x64ArchFiles": "Contents/Resources/app/app/projectGenerator"
are getting included from?
There was a problem hiding this comment.
Yeah all the mac:x calls use the mac { }.
The only one being used though in ci currently is dist:mac:universal
There was a problem hiding this comment.
okay - awesome.
looks good to me then!! 👍
Split up dev script code and ci code.
Now user can install... build and generate the cmd project / test / build electron all as separate steps controlled by script.
Update Electron to Latest. NPM to Latest (fixes bitcode on macOS)
Added VS front end gui building with output to projectGenerator-vs-gui to be added to releases
Added security code from apothecary been thinking about that does a checksum of the binary target, stores build time, and git version etc
macOS / VS command line builds as split the PG .sh
-TODO linux
TODO validate existing notorization and upload to apple for macOS is still working
Project generator