-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: updates to version and custom app icon handling #431
Conversation
…ON (Version) and CURRENT_PRODUCT_VERSION (Build) and note difference
…) and note about transitioning from oF 0.7.2-0.11 ICON_FILE_PATH variable
I was tempted to also change some formatting and add sections like:
... but I held off for now to keep this specific. I would also add a leading space to comments so:
becomes
... but that is a stylistic difference which doesn't have a huge impact other than my general pursuit of consistency. |
just fyi @danomatika To do the same for all OF apps you would need to modify the files here: |
Why would there need to be two copies of the Xcode project files? In any case, I can do a separate PR to OF tomorrow. |
@danomatika the ones at: https://github.com/openframeworks/openFrameworks/tree/master/scripts/templates/osx The ones in this repo are customized just for building the PG command line app and some of those settings we might not want to be global ( ie: in the same way the individual projects might want to have different Project.xconfig settings ). |
…y Xcode UI, whoops CURRENT_PROJECT_VERSION is the correct build version variable name
Latest commit uncomments version variables as they act as defaults are are overridden by the Xcode UI. Also, the build variable name is corrected to |
Awesome - thanks @danomatika !! |
This PR implements changes proposed in #429 and #430:
VERSION
into the defaultMARKETING_VERSION
andCURRENT_PROJECT_VERSION
variables to match Xcode UIICON_FILE_PATH
variable