Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/MD/XL-10029 empty line at file start for migration file #60

Conversation

mderis
Copy link
Collaborator

@mderis mderis commented Jan 5, 2025

Task XL-10029

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring a current feature, method, etc...)
  • Code Coverage (adding/removing/updating/refactoring tests)
  • New feature (non-breaking change which adds functionality)
  • Remove feature (non-breaking change which removes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mderis mderis added the bug Something isn't working label Jan 5, 2025
@mderis mderis requested a review from yalsicor January 5, 2025 10:12
@mderis mderis self-assigned this Jan 5, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 4.12%. Comparing base (195e1b4) to head (85fcb09).

Files with missing lines Patch % Lines
src/Generator/Commands/MigrationGenerator.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##             fix/MD/XL-10066-repository-generator     #60   +/-   ##
======================================================================
  Coverage                                    4.12%   4.12%           
  Complexity                                    901     901           
======================================================================
  Files                                         100     100           
  Lines                                        3366    3366           
======================================================================
  Hits                                          139     139           
  Misses                                       3227    3227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix/MD/XL-10066-repository-generator to refactor/MD/XL-8668-extend-apiato-custom-generator-command-loading January 6, 2025 09:46
@yalsicor yalsicor merged commit c1d9562 into refactor/MD/XL-8668-extend-apiato-custom-generator-command-loading Jan 6, 2025
3 checks passed
@yalsicor yalsicor deleted the fix/MD/XL-10029-empty-line-at-file-start-for-migration-file branch January 6, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants