feat: force user agent #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benoit382
commented
May 1, 2024
| @@ -120,6 +120,7 @@ class Api | |||
| * @param CacheInterface|null $cacheInterface | |||
| */ | |||
| public function __construct( | |||
| public readonly string $userAgent, | |||
There was a problem hiding this comment.
We could add the user agent at the end BUT nobody will use or define it.
|
|
be aware that this will introduce a breaking change. Not sure if forcing the useragent is really that important (no way to verify anyhow)?... if not, maybe revert this - or add as optional parameter at the end of the constructor? If we keep it in, we'd need to tag it as 0.4.x (at least) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Force the user agent
Clean of the previous PR #49
Issues
#48