feat: new localized product fields for generic name #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_get_save_product_test.dart`: set explicit language for `genericName` test to pass; also tested new field `genericNameInLanguages` * `product.dart`: added field `genericNameInLanguages` * `product.g.dart`: generated * `product_fields.dart`: added fields `GENERIC_NAME_IN_LANGUAGES` and `GENERIC_NAME_ALL_LANGUAGES`
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #828 +/- ##
==========================================
- Coverage 76.35% 76.04% -0.32%
==========================================
Files 205 205
Lines 7537 7546 +9
==========================================
- Hits 5755 5738 -17
- Misses 1782 1808 +26 ☔ View full report in Codecov by Sentry. |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
genericName, the same way it changed weeks ago aboutproductName. In short, now you're supposed to be explicit regarding the language you use, which is a good news. I fixed the test.Impacted files
api_get_save_product_test.dart: set explicit language forgenericNametest to pass; also tested new fieldgenericNameInLanguagesproduct.dart: added fieldgenericNameInLanguagesproduct.g.dart: generatedproduct_fields.dart: added fieldsGENERIC_NAME_IN_LANGUAGESandGENERIC_NAME_ALL_LANGUAGES