feat: new field pageCount for searchResult #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_get_user_products_test.dart`: now using `pageCount` instead of `count` * `api_search_products_test.dart`: skipped a test failing because of the server * `search_result.dart`: added field `pageCount` * `search_result.g.dart`: generated
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
==========================================
- Coverage 76.35% 76.00% -0.36%
==========================================
Files 205 205
Lines 7537 7539 +2
==========================================
- Hits 5755 5730 -25
- Misses 1782 1809 +27 ☔ View full report in Codecov by Sentry. |
g123k
approved these changes
Nov 15, 2023
teolemon
reviewed
Nov 15, 2023
| @@ -15,6 +15,9 @@ class SearchResult extends JsonObject { | |||
| @JsonKey(name: 'count', fromJson: JsonObject.parseInt) | |||
| final int? count; | |||
|
|
|||
There was a problem hiding this comment.
// page_count is the number of products requested per page. Please be mindful of server resources, and keep that below 200.
There was a problem hiding this comment.
page_count is the number of products requested per page.
AFAIK it's rather the number of products found within that result page.
|
Thank you @g123k for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
pageCountforSearchResultpageCount) and the "total number of products" (count).Impacted files:
api_get_user_products_test.dart: now usingpageCountinstead ofcountapi_search_products_test.dart: skipped a test failing because of the serversearch_result.dart: added fieldpageCountsearch_result.g.dart: generated