Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds opennsfw model #104

Merged
merged 2 commits into from
Nov 3, 2019
Merged

adds opennsfw model #104

merged 2 commits into from
Nov 3, 2019

Conversation

scottleedavis
Copy link
Contributor

Addresses Issue #103

@derek
Copy link

derek bot commented Oct 27, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Oct 27, 2019
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question sent

store.json Outdated Show resolved Hide resolved
@derek derek bot removed the no-dco label Oct 27, 2019
Signed-off-by: Scott Lee Davis <[email protected]>
Signed-off-by: Scott Lee Davis <[email protected]>
@scottleedavis
Copy link
Contributor Author

I followed the rebase approach you asked for previously in Issue #102 , and will improve my approach to the process of contributing to openfaas. I appreciate feedback always.

@alexellis
Copy link
Member

For future reference please see the recommendations we make in the contributing guide for formatting commit messages and the body of the commit message.

It's based upon this gem: https://chris.beams.io/posts/git-commit/

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 68540de into openfaas:master Nov 3, 2019
@alexellis
Copy link
Member

Merged, thank you for your awesome function.

For a follow-up PR, how about setting a memory requests value?

Using the metrics-server app from k3sup or the helm chart you can monitor the memory used then send in a recommended value for the function. I did this for the inception function which is quite heavy-weight - around 1GB.

https://k3sup.dev/

@scottleedavis
Copy link
Contributor Author

Hi @alexellis , I ran metrics-server, though I am not sure I captured it correctly it as the values are quite low.

NAME                                 CPU(cores)   MEMORY(bytes)
openfaas-opennsfw-5bcb55bb77-x9vhf   128m         28Mi

I did not see an example to borrow from in store & functions, or the stack.yml of inception or the workshop, so am not sure what to do next. Any thoughts much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants