-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds opennsfw model #104
adds opennsfw model #104
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question sent
Signed-off-by: Scott Lee Davis <[email protected]>
Signed-off-by: Scott Lee Davis <[email protected]>
I followed the rebase approach you asked for previously in Issue #102 , and will improve my approach to the process of contributing to openfaas. I appreciate feedback always. |
For future reference please see the recommendations we make in the contributing guide for formatting commit messages and the body of the commit message. It's based upon this gem: https://chris.beams.io/posts/git-commit/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Merged, thank you for your awesome function. For a follow-up PR, how about setting a memory requests value? Using the |
Hi @alexellis , I ran
I did not see an example to borrow from in store & functions, or the stack.yml of inception or the workshop, so am not sure what to do next. Any thoughts much appreciated. |
Addresses Issue #103