Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CAS ticket validation using ecphp/ecas #65

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Mar 30, 2023

This PR:

  • Introduces a new TicketValidationInterface concrete implementation, utilizing the ecphp/ecas library. This implementation does not return false but instead throws exceptions when issues arise, requiring users to handle exceptions appropriately. To ensure that developers catch exceptions as needed, we must verify that the calling code is equipped to handle them properly.
  • Test: The updated tests focus on evaluating the public interface, while private methods are indirectly tested through the expanded PHPUnit data provider list that accommodates various use cases. This approach enables thorough coverage of the codebase while maintaining appropriate encapsulation of private methods.
  • Is related to Request for comment - About TicketValidationInterface #64

@drupol drupol force-pushed the add/ecas-ticket-validation branch 3 times, most recently from 16cfab7 to 6833813 Compare April 1, 2023 16:07
Also add it to `require-dev` with its dependency for testing
@drupol drupol force-pushed the add/ecas-ticket-validation branch from 6833813 to bb96ece Compare October 19, 2023 13:50
@drupol drupol force-pushed the add/ecas-ticket-validation branch from bb96ece to fab0091 Compare October 19, 2023 13:56
@drupol drupol marked this pull request as ready for review October 19, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant