Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OE13 - Refactored cv divergence methods for Analysis class #225

Open
wants to merge 32 commits into
base: dev
Choose a base branch
from

Conversation

vinush-vignes
Copy link
Collaborator

@vinush-vignes vinush-vignes commented Jan 18, 2024

Ticket: https://recett-af.atlassian.net/jira/software/projects/OE/boards/1?selectedIssue=OE-13

  • This code need to be refactored in class-function format, and integrated with OpenEP Analysis tool
  • Add docstrings for each function
  • Optimise by reducing redundant variables.
  • Decoupled conduction velocity functions
  • Added interpolation method kws to be controlled from UI

@vinush-vignes vinush-vignes added enhancement New feature or request good first issue Good for newcomers labels Jan 18, 2024
@vinush-vignes vinush-vignes self-assigned this Jan 18, 2024
vinush-vignes and others added 7 commits January 24, 2024 18:16
OE21-BUG-FIX: Signal Viewer ecgNames hdf5 derefencing
* vtk load restored by stopping CV calc with vtk

* OE38-BUG: signalMaps index error (#228)

* added index error to signal maps import

* added index error to signal maps import

* handle empty ablation (#229)

* SM7: Read lon file (#1) (#231)

* created arrows class to store lines + vector visuals

* read lon to obtain fibres data

* write lon and elem files

* check linear connections and arrows exist before exporting

* create empty arrows class if arrows not provided

* export vtx files per pacing site

* Feature/SM-31: IGB data load (#2)

* load igb data

* added load igb to imports

* fibres filled with dummy values

* fibres filled with dummy values

* fibres filled with dummy values

* Feature/SM-45: Write to CSV (#3)

* export CSV writing to file using Panda

* Bugfix/SM-63 Empty signalmaps (#4)

* load empty signalMaps

* Feature/SM-18: Linear connections writer (#5)

* openCARP reader saves linear connection regions as separate data structure

* faster write function for openCARP data

* Feature/SM-45: Export CSV cell and histogram regions (#6)

* include histogram and cell region in csv export

* Bugfix/SM-86: Free boundaries as one actor (#8)

* combine free boundaries into a single actor

* not add rf to export openep if ablation == None (#9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants