Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/uncertainty zones #86

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Feature/uncertainty zones #86

wants to merge 39 commits into from

Conversation

drsewilliams
Copy link
Member

No description provided.

drsewilliams and others added 30 commits April 9, 2021 13:47
@drsewilliams
working on setting up interpolators
d94757d
@drsewilliams
Finished creating an initial version of openEPDataInterpolator.m
85182e9
@drsewilliams
Added getVoltages, modified getVertices and finished setting up the i…
8aca9cb 
…nterpolator class for scattered and local smoothing
@drsewilliams
Modified default values for scatteredInterpolant.m
2fc6fe4
@drsewilliams
Added blank functions for each of the conduction velocity calculation…
15e5f87 
… techniques
@adamcon
updates
a563386
updates to data interpolator class def
5f12d16
@drsewilliams
Added interpolation architecture diagram.drawio
ccd2379
@drsewilliams
created UML folder and moved draw.io diagram
d30c90c
@drsewilliams
Update interpolation architecture.drawio
75af0e3
@drsewilliams
Update interpolation architecture.drawio
63d354a
@drsewilliams
Finished first beta of conduction velocity architecture
0bdf113
@drsewilliams
Added triangulation method although this needs converted into "OpenEP…
3d8aa63 
…" format still
@drsewilliams
improved handling of trirep/triangulation. colouring shell based on g…
0595214 
…eodesic distances. plotting tags.
@drsewilliams
Refactored distanceBetweenPoints.m and distBetweenPoints.m. This is n…
19d6df9 
…ecessary to permit use of distBetweenPoints to calculate distances independently of userdata.
@drsewilliams
added uncertaintyZones.m function
7927b0d
@drsewilliams
Merge remote-tracking branch 'origin/feature/conduction_velocity' int…
e18a928 
…o feature/uncertainty_zones
@drsewilliams
Added a function to downsample an OpenEP dataset
e3e1116
@drsewilliams
small change to output
23b4445
@drsewilliams
Added functionality for rendering weights into drawMap
6731d68
@drsewilliams
Minor update to documentation fro getElectrogramX
cb30819
@drsewilliams
Change transposition of output and added a default region definition.
aba7636
@drsewilliams
adding weights
7b22935
@drsewilliams
Only compute normals if they do not already exist.
d044fc6
@drsewilliams
Merge remote-tracking branch 'origin/develop' into feature/uncertaint…
f07e06d 
…y_zones
@drsewilliams
Merge remote-tracking branch 'origin/develop' into feature/uncertaint…
2421303 
…y_zones
@drsewilliams
Merge remote-tracking branch 'origin/develop' into feature/uncertaint…
1a221f2 
…y_zones

# Conflicts:
#	getMesh.m
#	private/drawFreeBoundary.m
@drsewilliams
corrected problem with gettMesh.m arising from the previous merge
0ae8acb
@drsewilliams
corrected propblem with drawFreeBoundary.m arising from previous merge
6193815
@drsewilliams
Merge remote-tracking branch 'origin/develop' into feature/uncertaint…
c46b63b 
…y_zones
@codecov
Copy link

codecov bot commented May 10, 2023 •
edited
Loading

Codecov Report

Patch coverage: 6.41% and project coverage change: -0.90% ⚠️

Comparison is base (c808521) 21.03% compared to head (b879405) 20.14%.

❗ Current head b879405 differs from pull request most recent head bc18ccc. Consider uploading reports for the commit bc18ccc to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #86      +/-   ##
===========================================
- Coverage    21.03%   20.14%   -0.90%     
===========================================
  Files          147      164      +17     
  Lines         7136     7536     +400     
===========================================
+ Hits          1501     1518      +17     
- Misses        5635     6018     +383
Files Changed Coverage Δ
computeCVtriangulation.m 0.00% <0.00%> (ø)
doCvMapping_CosineFit.m 0.00% <0.00%> (ø)
doCvMapping_Eikonal.m 0.00% <0.00%> (ø)
doCvMapping_Gradient.m 0.00% <0.00%> (ø)
doCvMapping_Omnipole.m 0.00% <0.00%> (ø)
doCvMapping_RadialBasis.m 0.00% <0.00%> (ø)
doCvMapping_Triangulation.m 0.00% <0.00%> (ø)
getConductionVelocity.m 0.00% <0.00%> (ø)
getData2MeshGeodesicDistances.m 0.00% <0.00%> (ø)
getElectrogramX.m 0.00% <ø> (ø)
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklinton nicklinton nicklinton approved these changes

Assignees

@nicklinton nicklinton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drsewilliams @nicklinton @adamcon