Features/#766 develop h2 grid clustering #775
Conversation
|
So far, this branch is not dealing with buses with carrier "H2" or "H2_saltcavern". |
|
Since @ClaraBuettner can not be assigned like reviewer, is it OK for you @lenzim97 to review and approve this PR? |
|
Sorry, I thought I can create a PR and ask myself to review it. I can still do this and either accept that I just leave a comment as an approval or we close this PR and @CarlosEpia creates a new one I can review "officially" |
|
I like the first option better. @ClaraBuettner it is ok for me to receive the approval via comment and merge it when you say it. |
| @@ -166,7 +166,7 @@ def find_de_closest(network, bus_ne): | |||
| "H2_saltcavern": "power_to_H2", | |||
| "dsm": "dsm", | |||
| "Li ion": "BEV charger", | |||
| "Li_ion": "BEV_charger", | |||
There was a problem hiding this comment.
Li_ion is the carrier that is used in eGon2035 (and we also just changed it in eGon100RE), so it should not be deleted here
| @@ -166,7 +166,7 @@ def find_de_closest(network, bus_ne): | |||
| "H2_saltcavern": "power_to_H2", | |||
| "dsm": "dsm", | |||
| "Li ion": "BEV charger", | |||
| "Li_ion": "BEV_charger", | |||
| "O2": "power_to_O2", | |||
There was a problem hiding this comment.
Did you agree on this with @lenzim97?
As far as I know there will be no "power_to_O2" link anymore.
There was a problem hiding this comment.
Yes correct, i changed the carrier for the O2-links to "PtH2_O2", so there is no more "power_to_O2"-links
| ch4_network, weight_ch4, n_clusters_ch4 = preprocessing( | ||
| self, "CH4" | ||
| ) | ||
| if scn not in ["eGon2035", "status2019"]: |
There was a problem hiding this comment.
Do you think there is a more generic way for this, like checking if there are H2-pipelines?
If it stays like this we have to check for each new scenario if it is correct.
| @@ -124,6 +124,7 @@ | |||
| "cluster_foreign_AC": False, # take foreign AC buses into account, True or False | |||
| "method_gas": "kmedoids-dijkstra", # choose clustering method: kmeans or kmedoids-dijkstra | |||
| "n_clusters_gas": 14, # total number of resulting CH4 nodes (DE+foreign) | |||
| "n_clusters_h2": 14, # total number of resulting H2 nodes (DE+foreign) | |||
There was a problem hiding this comment.
This needs to be changed in the args.json as well
| @@ -124,6 +124,7 @@ | |||
| "cluster_foreign_AC": False, # take foreign AC buses into account, True or False | |||
| "method_gas": "kmedoids-dijkstra", # choose clustering method: kmeans or kmedoids-dijkstra | |||
| "n_clusters_gas": 14, # total number of resulting CH4 nodes (DE+foreign) | |||
There was a problem hiding this comment.
I always need at least 15 gas and H2 buses. Is that correct? If yes, I would change the default value here
Fixes #766