-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pietknoppert/fix runnable tests and update packages #361
Pietknoppert/fix runnable tests and update packages #361
Conversation
When running tests; '> @edx/[email protected] test > TZ=GMT fedx-scripts jest --coverage --passWithNoTests 'TZ' is not recognized as an internal or external command, operable program or batch file.' By installing cross-env this issue is fixed
Thanks for the pull request, @pietknoppert! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @pietknoppert, thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thanks! |
Hi @pietknoppert - just checking to see if you're planning to pursue this pull request? If so, have you been able to submit your CLA form? |
When testing the application i got these errors:
I installed cross-env and changed the test command. This fixed this issue.
And updated a few packages to decrease vulnerabilities.