-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fix invalid YAMLs in CRDs #620
base: develop
Are you sure you want to change the base?
Conversation
Chart lint failure. @nilroy Please check. |
@Abhinandan-Purkait I don't know what are the linting issue. I just copied the files from PR where the linting is passing. Could you help a bit here? |
Looks like a bug on our |
@tiagolobocastro Thanks for the pointer. Done that in 49bd37e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #620 +/- ##
===========================================
- Coverage 95.99% 95.27% -0.72%
===========================================
Files 1 1
Lines 574 593 +19
===========================================
+ Hits 551 565 +14
- Misses 19 23 +4
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nilanjan Roy <[email protected]>
Signed-off-by: Nilanjan Roy <[email protected]>
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
This fixes the invalid YAMLs in CRDs. It is a continuation from this PR
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>
PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>
.Where:
type
is defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md.Most common types are:
feat
- for new features, not a new feature for build scriptfix
- for bug fixes or improvements, not a fix for build scriptchore
- changes not related to production codedocs
- changes related to documentationstyle
- formatting, missing semi colons, linting fix etc; no significant production code changestest
- adding missing tests, refactoring tests; no production code changerefactor
- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changesscope
is a single word that best describes where the changes fit.Most common scopes are like:
localpv
,jiva
,cstor
)provisioning
,backup
,restore
,exporter
)api
,webhook
,cast
,upgrade
)tests
,bdd
)version
,build
,log
,travis
)subject
is a single line brief description of the changes made in the pull request.